Repository navigation
Release loader callbacks after compilation - #20531
Conversation
Cached compilers retain the module and stylesheet loader callbacks after compilation. Callbacks supplied by build tools can capture completed build state, keeping it alive during later builds. Capture the from and polyfills values used by subsequent builds and isolate config and plugin loading from the compatibility theme resolver's scope. This allows the loader callbacks and their captured state to be collected after compilation. Add a regression that keeps the compiler usable after both loader callbacks are collected.
 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughThe compiler captures source-location and polyfill options in local values. Compatibility config and plugin loading move into a helper. A new test checks whether stylesheet and module loader callbacks are released after compilation and whether the compiler can still build CSS containing Priority: ⬇️ Low
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the main change: releasing loader callbacks after compilation. |
| Description check | |
The description directly explains the callback lifetime issue, the implementation approach, regression coverage, and validation results. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
- Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Autopilot is currently an internal CodeRabbit preview.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
@RobinMalfait do you mind taking a look? 🙏 |
The integration test lived in `integrations/postcss` but does not use PostCSS, and it needed a full fixture install to run. The unit test gets `gc()` through `v8.setFlagsFromString` instead of the `--expose-gc` flag, so it runs with the rest of the `tailwindcss` tests.
3 participants
Summary
Cached compilers retain the module and stylesheet loader callbacks after compilation. Callbacks supplied by build tools can capture completed build state, keeping it alive during later builds.
Capture the
fromandpolyfillsvalues used by subsequent builds and isolate config and plugin loading from the compatibility theme resolver's scope. This allows the loader callbacks and their captured state to be collected after compilation.Test plan
The regression keeps the compiler alive across garbage collection, verifies that both loader callbacks can be collected, and confirms that a subsequent utility build still works.
corepack pnpm test:integrations postcss/compiler-lifetime.test.ts(Node.js 24.19.0)corepack pnpm run test(Node.js 24.19.0)corepack pnpm build(Node.js 22.23.3)The complete integration suite remains unverified locally because several framework fixtures require filesystem and network capabilities unavailable in the sandbox. Lint stopped on generated files and embedded templates; the scoped type check reports the same diagnostics on the unchanged base.